Skip to content

Conversation

@Ndaboom
Copy link
Contributor

@Ndaboom Ndaboom commented Apr 6, 2025

This fix sets explicit text colors for <h1> elements in both light and dark modes to ensure visibility and maintain visual contrast. A very dark gray (#adafae) is used for light mode to avoid pure black on white, improving readability and aesthetics, while a very light gray (#f8f9fa) is used in dark mode for optimal contrast.

@si458
Copy link
Collaborator

si458 commented Apr 8, 2025

this sadly hasnt really worked,
if you say use the darkly color scheme, and then switch your browser into light mode,
and check the my account page, the device groups are completely missing
image
but use dark mode for your browser and its perfectly fine
image

@Ndaboom
Copy link
Contributor Author

Ndaboom commented Apr 8, 2025

this sadly hasnt really worked, if you say use the darkly color scheme, and then switch your browser into light mode, and check the my account page, the device groups are completely missing image but use dark mode for your browser and its perfectly fine image

Oops, I tested with a MeshCentral instance without any device group(no devices data at all), which is why I couldn't see that part. I was only referring to the page titles to see if everything works. I will continue the work and push changes.
Thank you for the review.

@DaanSelen
Copy link
Contributor

this sadly hasnt really worked, if you say use the darkly color scheme, and then switch your browser into light mode, and check the my account page, the device groups are completely missing image but use dark mode for your browser and its perfectly fine image

Oops, I tested with a MeshCentral instance without any device group(no devices data at all), which is why I couldn't see that part. I was only referring to the page titles to see if everything works. I will continue the work and push changes. Thank you for the review.

Thank you for your time and effort in advance!

@si458
Copy link
Collaborator

si458 commented May 8, 2025

@Ndaboom sorry thats made it worse! and i was just using the default color theme in day mode
image

@DaanSelen
Copy link
Contributor

@Ndaboom is this still going on?

@Ndaboom
Copy link
Contributor Author

Ndaboom commented Jun 25, 2025

@Ndaboom is this still going on?

Yes, it is, but I haven't had a chance to continue working yet. I will follow up here very soon when I get something.
Thanks.

@Ndaboom Ndaboom force-pushed the fix-boostrap_ensures_title_consistency branch from ad2d55c to 7157422 Compare July 25, 2025 00:40
@Ndaboom Ndaboom changed the title [ENH] bootstrap themes: Ensure h1 titles remain visible across light and dark themes [ENH] bootstrap themes across light and dark themes Jul 30, 2025
@Ndaboom
Copy link
Contributor Author

Ndaboom commented Jul 30, 2025

Hi @si458, I've made a few changes. Could you test them when you have a chance?

Thank you.

@Ndaboom Ndaboom changed the title [ENH] bootstrap themes across light and dark themes [ENH] bootstrap themes across light and dark mode Jul 30, 2025
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Sep 29, 2025
@DaanSelen
Copy link
Contributor

Bump?

@github-actions github-actions bot removed the Stale label Sep 30, 2025
@marclaporte
Copy link
Collaborator

@Ndaboom What is the next step?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants