Weight Initialization Bug#15
Open
akleeman wants to merge 1 commit intoYannDubs:masterfrom
Open
Conversation
`get_activation_name` appears to be expected to return a string using the `mapper`, but was erroneously returning the key (a class, not a string)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_activation_nameappears to be expected to return a string using themapper, but I think it was erroneously returning the key (a class, not a string). This leads to a null operation inlinear_initsince all theif/elifstatements won't match.I suppose the result would have been some weights (in the MLP class for example) which weren't being initialized as intended. I can't imagine the consequences of such a bug would be large, but perhaps worth the fix?