Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a comprehensive filter modal for searching clubs, replacing the previous inline filter controls with a centralized modal interface. However, the implementation has critical issues where new filter states are not connected to the filtering logic, making several filters non-functional.
Key Changes:
- Introduced a new
FilterModalcomponent that consolidates all filtering options (schools, affiliations, intensity, application status, categories, and followed-only) into a single modal dialog - Added new state variables for intensity, application status, and separate affiliations filtering
- Updated the
Filtercomponent to show an up arrow indicator when the dropdown is open - Removed the default filter that previously showed only Yale College clubs
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| src/components/search/FilterModal.tsx | New modal component providing a centralized UI for all filter options with clear all functionality |
| src/components/search/SearchControl.tsx | Added state management for new filter types and integrated FilterModal; removed default Yale College filter |
| src/components/Filter.tsx | Enhanced dropdown indicator to show up arrow when open for improved visual feedback |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Added aria labels + changed school filtering default back to Yale College only Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI/UX Improvements:
FilterModalcomponent that displays all filter options in a modal dialog, allowing users to select multiple filters in one place and clear all selections easily. (src/components/search/FilterModal.tsx)Filtercomponent to show an up arrow (▲) when the dropdown is open, improving visual feedback for users. (src/components/Filter.tsx)Refactoring:
SearchControlwith the newFilterModal, simplifying the filter logic and UI. (src/components/search/SearchControl.tsx) [1] [2]SearchControlto manage all filter selections individually, supporting the expanded filter options in the modal. (src/components/search/SearchControl.tsx)