spec/build: Don't specify version controlled header as BYPRODUCTS. #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves an issue of the isa.h header being incorrectly regenerated when invoking the build a second time using the Ninja generator. This resulted in a broken build due to isa_disassembler being undefined in the regenerated header. Due to differences in CMake generators regarding to BYPRODUCS, the issue was not reproducible using the Unix Makefile generator https://cmake.org/cmake/help/latest/command/add_custom_target.html In general BYPRODUCTS is not intended to overwrite version controlled source files. This fixes issue Xilinx#144.
Author
|
This is still relevant even though #148 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
This resolves an issue of the
isa.hheader being unintendedly regenerated when invoking the build a second time using the Ninja generator.This resulted in a broken build due to isa_disassembler being undefined in the regenerated header.
Due to differences in CMake generators regarding to BYPRODUCS, the issue was not reproducible using the Unix Makefile generator
https://cmake.org/cmake/help/latest/command/add_custom_target.html
In general BYPRODUCTS is not intended to overwrite version controlled source files.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
This patch addresses the symptom of issue #144.
How problem was solved, alternative solutions (if any) and why they were rejected
Don't specify version controlled header as BYPRODUCTS.
A proper solution would be either not regenerating this header by the build system but by manually invoking the Python script and committing the result or not having the generated header in version control in case a regeneration is needed for every build. The current expected behavior did not require a regeneration for every build though.
More details can be found in #144.
Risks (if any) associated the changes in the commit
What has been tested and how, request additional testing if necessary
Documentation impact (if any)