fix: Preventing attacker to suppress AMM trading fees indefinitely and extract value from liquidity providers - #7867
Open
Kassaking7 wants to merge 1 commit into
Open
fix: Preventing attacker to suppress AMM trading fees indefinitely and extract value from liquidity providers#7867Kassaking7 wants to merge 1 commit into
Kassaking7 wants to merge 1 commit into
Conversation
Kassaking7
changed the title
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
An attacker will suppress AMM trading fees indefinitely and extract value from liquidity providers: Failure to invalidate vote slots and recompute the trading fee after a full LP withdrawal will cause persistent fee manipulation losses for liquidity providers as an attacker will perform a flash deposit, vote for a reduced fee, withdraw all liquidity, and leave a stale vote that continues to control the pool fee.
Context of Change
API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)