feat: Experimental: Add more specific error messages in submit/simulate - #7848
Draft
mvadari wants to merge 8 commits into
Draft
feat: Experimental: Add more specific error messages in submit/simulate#7848mvadari wants to merge 8 commits into
mvadari wants to merge 8 commits into
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR refactors the error code return spots to add the log line in that shows up there, which can be returned in
submit/simulatefor easier debugThis is an experimental vibe-coded version for PoC purposes
Sample output:
Context of Change
easier debugging
API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)