fix: use multi-arch devcontainer base image for universal compatibility#2
Open
joshuahamsa wants to merge 1 commit into
Open
fix: use multi-arch devcontainer base image for universal compatibility#2joshuahamsa wants to merge 1 commit into
joshuahamsa wants to merge 1 commit into
Conversation
Switch from universal:2 (linux/amd64 only) to base:ubuntu, which is published for both amd64 and arm64. This lets the devcontainer build natively on Apple Silicon as well as Intel/AMD hosts. Since base:ubuntu is minimal, add the node and python features that universal:2 previously provided, so setup.sh (npm, pip, mint-wallets) continues to work. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The devcontainer used
mcr.microsoft.com/devcontainers/universal:2, which is only published forlinux/amd64. On Apple Silicon (arm64) hosts this fails to build natively (or runs slowly under emulation).Fix
Switch to
mcr.microsoft.com/devcontainers/base:ubuntu, a multi-arch image published for bothamd64andarm64. This builds natively on Intel/AMD and Apple Silicon.Because
base:ubuntuis minimal (unlikeuniversal:2, it ships neither Node nor Python), this PR also adds the official multi-archnodeandpythonfeatures so thatsetup.sh(npm install, pip install xrpl-py) and the wallet-minting step continue to work.Testing
Built successfully via
devcontainer upon macOS arm64 (Apple Silicon).🤖 Generated with Claude Code