fix: await sealMessage which is now async#12
Closed
avral wants to merge 1 commit intoXPRNetwork:masterfrom
Closed
Conversation
sealMessage from @wharfkit/protocol-esr is now an async function,
but it was being called without await. This caused the Promise object
to be serialized as an empty object {}, resulting in empty message
being sent to the Buoy callback service (400 Bad Request: "Unable to
forward empty message").
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Collaborator
|
Hello! Thank you for the PR. Yes it is caused by It should be reviewed and released soon |
Collaborator
|
@avral New version of @proton/wharfkit-plugin-webauth released. It already has this change. Feel free to update and try. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sealMessagefrom@wharfkit/protocol-esris now an async function, but it was being called withoutawait. This caused the Promise object to be serialized as an empty object{}, resulting in an empty message being sent to the Buoy callback service.Error:
POST https://cb.anchor.link/... 400 (Bad Request)with body"Unable to forward empty message"Root Cause
In
@wharfkit/protocol-esrv1.6.0,sealMessageis defined as:But in this plugin it was called without await:
When
Serializer.encode({ object: sealedMessage })is called on a Promise, it produces an empty byte array.Fix
Test Plan
🤖 Generated with Claude Code