Skip to content

UI: Show known status and pickpocket requirements in the same line in tooltip#930

Draft
lostindark wants to merge 1 commit intoWowRarity:masterfrom
lostindark:master
Draft

UI: Show known status and pickpocket requirements in the same line in tooltip#930
lostindark wants to merge 1 commit intoWowRarity:masterfrom
lostindark:master

Conversation

@lostindark
Copy link
Copy Markdown

@lostindark lostindark commented Dec 16, 2025

Before:
image

After:
image

@rdw-software
Copy link
Copy Markdown
Member

Thanks for the proposal! This branch will have to be rebased onto the latest tooltip changes once those are ready. There's some alpha/WIP changes that conflict, so I'll need to see how easily they can be integrated. It probably won't happen before January.

Note that the tooltip line rendering has been more or less rewritten and this may well be obsoleted - if an option you'd like to see is missing, we can add it more easily once the new approach has been applied to unit tooltips (and potential bugs ironed out).

(Tangentially and generally speaking, motivating changes and having English locale screenshots available would be ideal)

@rdw-software
Copy link
Copy Markdown
Member

Here's how this looks on the English client.

Before:

image

After:

image

Is that really an improvement? It seems... too wide. Maybe it would be better to make the tooltip text configurable (with placeholders or at least presets) so that people can adjust it and account for language differences themselves if need be?

(Suggestions welcome, I'll hold off on this as it's a minor cosmetic change and there's more important things on the horizon)

@lostindark
Copy link
Copy Markdown
Author

If you look closely, the before version for Chinese doesn't only shows about half of the items and the rest is cut off due to too many items and doesn't fit the screen. After the change each item only takes 1 lines (instead of 3) so it can display more items in screen (good for those npcs/items that drops a lot of items).

Yes I agree for English it is probably too wide. Better to have configuration to customize the behavior.

@rdw-software
Copy link
Copy Markdown
Member

rdw-software commented Jan 3, 2026

That's a good point. Let me finish the unit tooltip cleanup first and then we can either get this integrated, or find a different solution (that still fixes the UI problem for your locale). It'll probably take a while, so I'll leave this PR open as a reminder.

@rdw-software rdw-software marked this pull request as draft January 3, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants