Update SQLite refresh script to support the SQLite monorepo#3452
Merged
Update SQLite refresh script to support the SQLite monorepo#3452
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the SQLite integration plugin refresh flow to work with the upstream sqlite-database-integration monorepo by building a ZIP from a shallow clone, while keeping a fallback path for older (pre-monorepo) releases.
Changes:
- Switch refresh script from downloading GitHub archives to shallow-cloning and running the upstream build script when available
- Add fallback to archive download for older tags that don’t contain the build script
- Update the expected ZIP size for
trunkin module details
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| packages/playground/wordpress-builds/src/sqlite-database-integration/get-sqlite-driver-module-details.ts | Updates expected size metadata for the trunk ZIP |
| packages/playground/wordpress-builds/build/refresh-sqlite-integration-plugin.js | Implements clone+build flow for monorepo versions with a legacy archive-download fallback |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/playground/wordpress-builds/build/refresh-sqlite-integration-plugin.js
Show resolved
Hide resolved
packages/playground/wordpress-builds/build/refresh-sqlite-integration-plugin.js
Show resolved
Hide resolved
packages/playground/wordpress-builds/build/refresh-sqlite-integration-plugin.js
Show resolved
Hide resolved
packages/playground/wordpress-builds/build/refresh-sqlite-integration-plugin.js
Outdated
Show resolved
Hide resolved
...yground/wordpress-builds/src/sqlite-database-integration/get-sqlite-driver-module-details.ts
Show resolved
Hide resolved
Done via: npx nx run playground-wordpress-builds:bundle-sqlite-database
a327517 to
6ee2478
Compare
Member
Author
|
I'll merge this one to re-enable the SQLite refresh job. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bin/build-sqlite-plugin-zip.sh) to produce a self-contained plugin ZIP with the driver symlink resolved.Test plan
npx nx run playground-wordpress-builds:bundle-sqlite-databasesucceeds for bothtrunkandv2.1.16db.copy,load.php, and a realwp-includes/database/directorynpm run devand confirm SQLite works)