Add backslash coverage to wp_options LIKE escaping tests#468
Merged
Conversation
The escaping tests asserted % and _ are escaped, and the comments note
esc_like() also covers the \ escape character, but no case exercised it.
Add a backslash-prefix case to both the option-meta and parity tests;
each was confirmed to fail against the previous str_replace('_','\_')
escaping (which left \ active) and pass with esc_like().
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test-only follow-up to #462 / #467 (review feedback).
The
wp_optionsLIKE-escaping regression tests asserted that%and_are escaped, and the comments noteesc_like()also covers the\escape character — but no test case exercised\. This adds a backslash-prefix case to both:tests/php/includes/functions/test-acf-option-meta-like-escaping.phptests/php/includes/test-like-escaping-parity.phpEach new case was confirmed to fail against the previous
str_replace( '_', '\_', … )escaping (which left\active) and pass withesc_like(), so the tests now fully match their stated claim.No production code changes.
composer test:php(the two classes): OK (7 tests).phpcs: clean.Use of AI Tools
Authored by Claude Code (Claude Fable 5) under human direction.