Replace basestring with str type to support Python3 #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python3 does not have a "basestring" type (as per: https://stackoverflow.com/questions/34803467/unexpected-exception-name-basestring-is-not-defined-when-invoking-ansible2) and the recommended action is to replace it with the "str" type Issue(s): None
srkiNZ84
changed the title
|
+1 |
bloodpet
approved these changes
Sep 1, 2017
|
Is there any chance this could get merged any time soon? |
|
Hey there, Ansible is currently using |
|
ping :) |
Author
|
I haven't got the permissions to merge this PR and it looks like the repository hasn't been committed to since 2016. Think the Ansible module might need to change the dependency or find a different DigitalOcean library to use. |
|
@srkiNZ84 we can get in touch with wirecraft or ask to pypi to provide another source for the package distribution... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python3 does not have a "basestring" type (as per:
https://stackoverflow.com/questions/34803467/unexpected-exception-name-basestring-is-not-defined-when-invoking-ansible2)
and the recommended action is to replace it with the "str" type.
This was the only instance of it that I managed to find in the repository.
Issue(s): None