vb6run: Update version to 6.0.98.2#2496
Open
arethusa26 wants to merge 1 commit intoWinetricks:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The version of the Visual Basic 6 runtime currently installed by winetricks is old enough that its SendKeys implementation is incompatible with modern Windows and Wine as of 8.20 with commit e1259ff91a40d7d97fa730235e2b7737b229f708 because it requires successful WH_JOURNALPLAYBACK hooking with SetWindowsHookEx, as discussed in Wine bug 58198. Wine unconditionally disallows journal hooks and Windows requires additional permissions to be granted for such hooks to be installed, so SendKeys cannot work in such old runtime versions.
A visible consequence of the incompatibility can be seen in the VARA HF application, which displays a nuisance "Notepad.exe not found" message box as a result of SendKeys failure when opening a log file.
As discussed in a blog post, later versions of the Visual Basic 6 runtime include a graceful fall back to the user32 SendInput function if SendKeys cannot install the necessary journal hook. The version of the VB6 runtime available in Windows XP SP3 is new enough to include this logic, so the vb6run verb in winetricks is updated to use the existing helpers for the XP SP3 redist for installation of the updated msvbvm60.dll.