vcrun2017/2019/2022: fix msvcp140_2.dll not being replaced on Wine 11+#2495
Open
SurenIV wants to merge 1 commit intoWinetricks:masterfrom
Open
vcrun2017/2019/2022: fix msvcp140_2.dll not being replaced on Wine 11+#2495SurenIV wants to merge 1 commit intoWinetricks:masterfrom
SurenIV wants to merge 1 commit intoWinetricks:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wine 11+ ships builtin msvcp140_2.dll with a higher version number (14.50) than what vcredist provides (14.44). The Microsoft installer compares versions and refuses to downgrade, leaving the builtin in place instead of replacing it with the native DLL.
A workaround for msvcp140.dll already exists (see #2465), but msvcp140_2.dll has the same problem and is not being replaced.
This PR adds manual extraction of msvcp140_2.dll from the vcredist cabinet files for vcrun2017, vcrun2019, and vcrun2022, similar to what is already done for vcrun2026.
Related: #2464, #2465