uplay: update workarounds

[Kreyren]

As refferenced on PhoenicisOrg/scripts#978 uplay needs application settings on winvista for upc.exe and UbisoftGameLauncher.exe to avoid rendering issues (PhoenicisOrg/scripts#965 (comment)).

Reproduced this issue on winetricks using wine-4.9 (Staging) on debian buster.

EDIT: Updated based on previous results, not tested.

EDIT2: Tested working on my system as presented in comments.

[austin987]

Triaging.

[Kreyren]

Triaging.

oh shi!@#, sorry forgot about this, required changes are submitted.

Note that this is not tested since my current system is unable to reproduce the issue (system without GPU). Fix is submitted based on previous results.

[austin987]

Please squash the commits.

[Kreyren]

I set up a system to test this.

aptli: http://ix.io/1UYd

Issue still present (uplay window):

Issue present with presented fix -> Assuming that Win7 environment might be affecting this -> investigating

winxp environment using winxp seems to resolve this

Confirmed fix using winxp environment and upc.exe + UbisoftGameLauncher.exe set on winvista.

Investigating to avoid using winxp globally -> Set the uplay executables with variation of different environments, but the result is as follows:

The client seems to works even with this message.

Seems that UplayWebCore.exe is the problem for rendering issues.

---

NSIS Error

Reproducable: always assuming new wineprefix

Current results with output https://gist.githubusercontent.com/Kreyren/97ca590d0131ed3a23b4646d2e8b8898/raw/c947adf9f99febd96623804975b8187d2a9c3a04/gagafd and popup:

---------------------------
NSIS Error
---------------------------
Installer integrity check has failed. Common causes include
incomplete download and damaged media. Contact the
installer's author to obtain a new copy.

More information at:
http://nsis.sf.net/NSIS_Error
---------------------------
OK   
---------------------------

This seems as new issue, investigating -> Resolved

• References
  https://ubuntuforums.org/showthread.php?t=1754649 - Points to corrupted file on upstream.
  https://nsis.sourceforge.io/Why_do_I_get_NSIS_Error - Points to corrupted file on upstream.
  https://www.winehq.org/pipermail/wine-users/2009-February/048568.html - Possible workaround

• Solved NSIS issue

kreyren@dreamon:~$ rm .cache/winetricks/uplay/ -r
kreyren@dreamon:~$ /usr/src/winetricks/src/winetricks uplay
------------------------------------------------------
You are using a 64-bit WINEPREFIX. Note that many verbs only install 32-bit versions of packages. If you encounter problems, please retest in a clean 32-bit WINEPREFIX before reporting a bug.
------------------------------------------------------
Using winetricks 20190912-next - sha256sum: 61cac187f6dfcd3fec8942694f0809e321db4c320b4e6e1af1c6bf776d79c279 with wine-4.15 (Staging) and WINEARCH=win64
Executing w_do_call uplay
Executing load_uplay 
Executing mkdir -p /home/kreyren/.cache/winetricks/uplay
Executing cd /home/kreyren/.cache/winetricks/uplay
Downloading https://static3.cdn.ubi.com/orbit/launcher_installer/UplayInstaller.exe to /home/kreyren/.cache/winetricks/uplay
--2019-09-13 03:04:57--  https://static3.cdn.ubi.com/orbit/launcher_installer/UplayInstaller.exe
Resolving static3.cdn.ubi.com (static3.cdn.ubi.com)... 2.17.13.158
Connecting to static3.cdn.ubi.com (static3.cdn.ubi.com)|2.17.13.158|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 103654440 (99M) [application/octet-stream]
Saving to: ���UplayInstaller.exe���

UplayInstaller.exe  100%[===================>]  98.85M  15.8MB/s    in 6.2s    

2019-09-13 03:05:03 (16.0 MB/s) - ���UplayInstaller.exe��� saved [103654440/103654440]

Executing cd /home/kreyren
Executing cd /home/kreyren/.cache/winetricks/uplay
Executing wine UplayInstaller.exe
000b:fixme:thread:create_user_shared_data_thread Creating user shared data update thread.
000b:fixme:winediag:start_process Wine Staging 4.15 is a testing version containing experimental patches.
000b:fixme:winediag:start_process Please mention your exact version when filing bug reports on winehq.org.
000f:fixme:thread:create_user_shared_data_thread Creating user shared data update thread.
000d:fixme:thread:create_user_shared_data_thread Creating user shared data update thread.
0012:fixme:thread:create_user_shared_data_thread Creating user shared data update thread.
0014:fixme:thread:create_user_shared_data_thread Creating user shared data update thread.
001b:fixme:thread:create_user_shared_data_thread Creating user shared data update thread.
0021:fixme:thread:create_user_shared_data_thread Creating user shared data update thread.
<installer launches>

[Kreyren]

oops, synced wrong branch.

EDIT: fixed

[Kreyren]

@austin987 for solution in #1249 (comment) Should i make some logic to remove said file based on file's modify date to prevent similar issues?

EDIT: probably for another MR

[Kreyren]

INFO: Seems that w_set_app_winver() is not creating expected environment.

EDIT: confirmed

EDIT2: pebcak

[Kreyren]

@austin987 Ready for review this works on my system without issues so far excluding annoying pop-up message about crash within the uplay which doesn't prevent the wineapp from working.

[loannaflip]

cool

[Kreyren]

minor edit