Replace visual breast physics with weighted deformation.#398
Open
OnlyJugs wants to merge 3 commits intoWildfireRomeo:fabric-1.21.11from
Open
Replace visual breast physics with weighted deformation.#398OnlyJugs wants to merge 3 commits intoWildfireRomeo:fabric-1.21.11from
OnlyJugs wants to merge 3 commits intoWildfireRomeo:fabric-1.21.11from
Conversation
OnlyJugs
force-pushed
the
fabric-1.21.11-experimental
branch
from
3fd2692 to
ea72eb8
Compare
OnlyJugs
changed the title
OnlyJugs
changed the title
Contributor
Author
|
Alright, now it looks fully complete. I did some more testing and noticed that the swaying didn't deform as it should. |
|
|
||
| protected void renderGlint(PoseStack matrixStack, SubmitNodeCollector renderQueue, S state, BreastModelBox box) { | ||
| protected void renderGlint(PoseStack matrixStack, SubmitNodeCollector renderQueue, S state, BreastModelBox box, BreastSide side) { | ||
| PhysicsDeformation physics = createPhysicsDeformation(side); |
Collaborator
There was a problem hiding this comment.
is there a reason why you're creating this again instead of providing the instance the caller already has?
Comment on lines
226
to
227
| // Physics translations removed from the matrix stack — now applied per-vertex in renderBox() | ||
| // weighted by Y-distance from the attachment edge, so the base stays anchored to the body. |
Collaborator
There was a problem hiding this comment.
redundant comments - was this generated by an llm?
… back to pre-pull speed
Owner
|
I will look into this when I can. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of PR is this?
What changes does this PR make?
It replaces the breasts' visual physics effects with proper deformation, so the breasts move in a more natural attached looking way rather than as two blocks that move independently from the body (even though they technically still do).
Anything else we should know?
The existing physics simulation is still the same. Only how the output is applied to the breasts is different. I hope this ends up in the mod, as I am quite proud of the results and believe lots of people would like the visual change.