WhiteVPN tray icon does not restore the window on Ubuntu

[blue-sky1020]

On Ubuntu 22.04 (GNOME, X11), closing WhiteVPN sends it to the system tray, but clicking the tray icon does not restore the main window.

Launching WhiteVPN again creates a second window and a second tray icon instead of restoring the existing instance.

Version: 1.0.19
Package: WhiteVPN-Desktop-1.0.19-linux-amd64.deb

[DarkPoesidon]

Reopening this deliberately. The fix is merged (#96) and in v1.0.21-rc1, but the PR's Closes keyword closed this automatically and the fix has not actually been seen working.

Two faults were found and fixed:

1. The tray's ready callback never returned. systray releases a WaitGroup only when that callback returns, and on Linux the D-Bus method a host calls to read the menu — GetLayout — waits on it first. So the icon was drawn, the click arrived, and the host sat waiting for a layout that never came.
2. SetOnTapped was registered too late, racing with the export of the icon's D-Bus properties. Losing that race meant the icon announced itself as ItemIsMenu, and no host sends Activate to one of those.

Both were read out of systray v1.12.2's source rather than from a reproduction. Nobody here has an Ubuntu GNOME/X11 desktop to test on, and that part cannot honestly be unit-tested — seeing a host send Activate needs a session and a bus.

So: if you are able to try WhiteVPN-Desktop-1.0.21-rc1-linux-amd64.deb and say whether a single click on the tray icon now brings the window back, that would settle it. If it does, this can close for real.

Note the asset name: the plain linux-amd64 package is now the WebKitGTK 4.1 build. On Ubuntu 22.04 take linux-amd64-webkit40.deb instead.

---

این ایشو را عمداً باز کردم. فیکس مرج شده و در نسخهٔ ۱.۰.۲۱-rc1 هست، ولی کلمهٔ Closes در PR خودکار بست و در واقع کسی ندیده که کار کند.

تشخیص از روی سورس خود systray است نه از روی بازتولید، و ما دسترسی به دسکتاپ Ubuntu با GNOME/X11 نداریم. اگر بتوانید فایل linux-amd64.deb نسخهٔ rc1 را امتحان کنید و بگویید کلیک روی آیکون تری پنجره را برمی‌گرداند یا نه، تکلیفش روشن می‌شود.