Cache the children after a getBinaryNodeChild/ren call to avoid traversing arrays #2093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for opening this pull request and contributing to the project! The next step is for the maintainers to review your changes. If everything looks good, it will be approved and merged into the main branch. In the meantime, anyone in the community is encouraged to test this pull request and provide feedback. ✅ How to confirm it worksIf you’ve tested this PR, please comment below with: This helps us speed up the review and merge process. 📦 To test this PR locally:If you encounter any issues or have feedback, feel free to comment as well. |
purpshell
force-pushed
the
feat/cached-getBinary
branch
from
476e4e9 to
84f159f
Compare
purpshell
force-pushed
the
feat/cached-getBinary
branch
from
bd27831 to
e2be5c9
Compare
jlucaso1
approved these changes
Nov 20, 2025
Salientekill
pushed a commit
to Salientekill/Baileys
that referenced
this pull request
Nov 20, 2025
…aster processing Implements node caching using WeakMap to dramatically improve performance when accessing binary node children. Performance improvements: - 30x faster getBinaryNodeChildren operations - 10x faster getBinaryNodeChild operations Implementation: - Uses WeakMap for automatic garbage collection - No memory leaks - nodes are GC'd when no longer in use - Caches node locations to avoid traversing entire children array This is an experimental performance optimization that significantly speeds up binary node processing operations throughout the codebase. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
purpshell
force-pushed
the
feat/cached-getBinary
branch
from
6c1bf68 to
e2be5c9
Compare
Salientekill
pushed a commit
to Salientekill/Baileys
that referenced
this pull request
Nov 24, 2025
…aster processing
Salientekill
pushed a commit
to Salientekill/Baileys
that referenced
this pull request
Nov 24, 2025
…aster processing
Salientekill
pushed a commit
to Salientekill/Baileys
that referenced
this pull request
Nov 24, 2025
…aster processing
Salientekill
pushed a commit
to Salientekill/Baileys
that referenced
this pull request
Nov 25, 2025
Salientekill
pushed a commit
to Salientekill/Baileys
that referenced
this pull request
Nov 25, 2025
Salientekill
pushed a commit
to Salientekill/Baileys
that referenced
this pull request
Nov 25, 2025
Salientekill
pushed a commit
to Salientekill/Baileys
that referenced
this pull request
Nov 27, 2025
…rformance Add WeakMap-based caching for binary node child lookups to improve performance. Changes: - Add indexCache using WeakMap to cache node child indexes - Optimize getBinaryNodeChildren to use cached index - Build index once per node and reuse for subsequent lookups - Update getBinaryNodeChild to use new optimized getBinaryNodeChildren - Increase type safety with proper return types 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
purpshell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experimental change, so I thought I will put it in a PR.
This PR does one thing: it caches each node the getBinaryNodeChild and getBinaryNodeChildren function receives, so we don't have to traverse the entire children array to know where each node is.
This implementation uses the WeakMap , which means all the nodes will be GC'd automatically when no longer in use. Memory leaks remain a point of discussion for this PR.
This PR achieves 30x speed in getBinaryNodeChildren and 10x speed in getBinaryNodeChild.