-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
fix: remove lru-cache and reduce ttls to avoid memory leaks #1894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for opening this pull request and contributing to the project! The next step is for the maintainers to review your changes. If everything looks good, it will be approved and merged into the main branch. In the meantime, anyone in the community is encouraged to test this pull request and provide feedback. ✅ How to confirm it worksIf you’ve tested this PR, please comment below with: This helps us speed up the review and merge process. 📦 To test this PR locally:If you encounter any issues or have feedback, feel free to comment as well. |
jlucaso1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch
|
I dont think make sense to remove the LRU cache, it already had TTL and the fact node cache doesnt support update ttl on get will make it try to migrate/store again wrongly even when its being used constantly |
On big projects the memory can grow too fast with 7 days TTL, we can update manually the TTL (re-adding the key) what do you think? |
I think it would be a good approach too, or just decrease the TTL |
purpshell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not keep on jumping back and forth in dependencies.
Is there a fundamental issue with lru-cache itself? Why node-cache?
I think |
|
This PR is stale because it has been open for 14 days with no activity. Remove the stale label or comment or this will be closed in 14 days |
…to avoid memory leaks - Remove lru-cache dependency causing memory leaks - Reduce cache TTLs to prevent memory buildup - Add NodeCache for lid-mapping with 1h TTL - Add message retry manager utilities - Update libsignal with memory optimizations 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
bd1c658 to
f46e8b1
Compare
No description provided.