-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
feat: new libsignal (wip, breaking change) #1805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for opening this pull request and contributing to the project! The next step is for the maintainers to review your changes. If everything looks good, it will be approved and merged into the main branch. In the meantime, anyone in the community is encouraged to test this pull request and provide feedback. ✅ How to confirm it worksIf you’ve tested this PR, please comment below with: This helps us speed up the review and merge process. 📦 To test this PR locally:If you encounter any issues or have feedback, feel free to comment as well. |
|
great job @vinikjkkj |
ec90a4b to
dd00098
Compare
|
fixed, i'll work on the rest later |
Can I download and test it? Is it usable? |
|
@Salientekill only 1-1 dm messages are working, so is not stable yet |
|
it's working on dm and groups |
|
@vinikjkkj oops I misunderstood, sorry |
|
Deu erro ao tentar utilizar: |
dd00098 to
2b4518b
Compare
2b4518b to
374ccb7
Compare
|
I did the test, I only had problems with freezing, I sent messages in private and then in the group it stopped responding, and from time to time the messages were being ignored in the groups |
did you clear your sessions & sender key states? |
Can we migrate this somehow? I don't think we can merge a change like this while having it break. |
I deleted the connection and connected again to generate everything new, so I didn't have any problems, but I had this crash issue, João is in my group and I told him about it, it could be my code |
038216d to
54db127
Compare
|
I found it interesting, and as soon as Jlucaso's PR from ctoken is merged, I will test this one because it seems quite promising, and perhaps it will solve current freezing and other problems I've been having. |
|
@vinikjkkj I tried to install it to test it, but unfortunately I'm unable to download it. Could you please contact Pushmaster and fix the problems? error: |
purpshell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, jlucaso1 finished up most of his Rust implementation and I believe it is a better fit for the project since:
- if WhatsApp makes some breaking change in their library, it will cascade down eventually to our code which is a vector
- It could be an automation detection vector somehow eventually
- It could be a security / enc risk
- Performance gain is minimal compared to Rust based WASM
- We can control the source code and execution context, we might turn the WASM approach back into N-API if we wished so, additionally we can make more performance improvements than simply relying on whatsapp web's signal which assumes each session has gigabytes of ram and lots of CPU to play with.
Other than that, I believe your ideas are super creative and I love this one specifically. Keep tinkering man!!
|
This PR is stale because it has been open for 14 days with no activity. Remove the stale label or comment or this will be closed in 14 days |
I created a new libsignal that uses Whatsapp Web native methods, I need that you test.
Need to Work:
This libsignal will break your session-* sender-key*, delete them to reuse an existent session