Always run tests for all apps #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing matrix strategy only tests apps which have been changed directly. This is unsound, since other apps may be affected by a change, but not directly changed, and hence gone untested. This change makes sure all apps are tested every time. We exchange the compute cost of running more tests for greater confidence in our changes.
potatosalad
approved these changes
Jun 13, 2023
potatosalad
force-pushed
the
wa/main
branch
from
82528ed to
d051172
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing matrix strategy only tests apps which have been changed directly. This is unsound, since other apps may be affected by a change, but not directly changed, and hence gone untested. This change makes sure all apps are tested every time. We exchange the compute cost of running more tests for greater confidence in our changes.