Skip to content

Add linter for charts #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add linter for charts #357

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
475b54a
Add linter for charts
peixian Feb 19, 2025
3ac1e13
Limit to yml files
peixian Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/yaml-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
- name: 'Yamllint'
uses: karancode/yamllint-github-action@master
with:
yamllint_file_or_dir: 'charts/whatsapp-proxy-chart/*/*'
yamllint_file_or_dir: 'charts/whatsapp-proxy-chart/*/*.yml'
Copy link
Contributor

@eozturk1 eozturk1 Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we need to add *.yaml here as well because almost all of our files are .yamls.

Copy link
Member Author

@peixian peixian Feb 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about it more, I'm pretty sure helm charts actually fail yamllint, since the interpolation isn't yaml standard. I don't think we can use this, we'll need to do a helm lint instead per sbaudoin/yamllint#16 (comment)

Copy link
Member Author

@peixian peixian Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use https://github.com/helm/chart-testing-action instead. Although neither of these would catch the procotcl misspelling error, as there's no defined spec for it. It'd catch invalid formatting, but not invalid keys.

yamllint_strict: false
yamllint_comment: true
env:
Expand Down