Fix command line option parsing

[pacak]

Positional arguments in 0.9 version of bpaf must go to the right most position.

Fixes #85

[pacak]

It is possible to add a test to catch those issues and I might do just that later once I figure out how to compile all this stuff.

Plus this restriction is going away in the next version once I get around releasing it.

[facebook-github-bot]

@alanz has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[alanz]

@pacak Thanks for this. I see that there is another occurrence too. I will fix it, and add tests.

[pacak]

https://docs.rs/bpaf/0.9.16/bpaf/struct.OptionParser.html#method.check_invariants - this is the way to test.

[alanz]

I am intending to add tests like

erlang-language-platform/crates/elp/src/bin/main.rs

Line 1769 in 9b265d7

fn eqwalize_all_help() {

, which also documents the usage.

[pacak]

I am intending to add tests like

This works, but you need to make sure to call --help for every nested subcommand, if they are present. With check_invariants you only need to add it on the top level. Up to you I guess.

[alanz]

Adding

#[cfg(test)]
mod tests {

    use bpaf::Parser;
    use super::command;

    #[test]
    fn check_options() {
        command().to_options().check_invariants(false)
    }
}

to the end of args.rs does as you say. But it sends a lot of stuff to stdout, even though the test passes. Is this expected?

[pacak]

But it sends a lot of stuff to stdout, even though the test passes. Is this expected?

Yes. If test succeeds - output is captured by the test runner and dropped, but if test fails - this output helps to figure out what exactly needs to be fixed.

[facebook-github-bot]

@alanz merged this pull request in 94ecd0f.