Fix issue where W0008 could not be disabled

[lukebakken]

Fixes #113

[meta-cla]

Hi @lukebakken!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[meta-cla]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[robertoaloi]

Thanks!

Out of curiosity, is there any reason why you want to disable this linter? Is it generating false positives?

[facebook-github-bot]

@robertoaloi has imported this pull request. If you are a Meta employee, you can view this in D80779500.

[robertoaloi]

@lukebakken There's a formatting issue on diagnostics.rs. Apart from that, it looks good.

[lukebakken]

Out of curiosity, is there any reason why you want to disable this linter? Is it generating false positives?

Most of the RabbitMQ Common Test suites export everything, which generates a lot of false positives.

[lukebakken]

@robertoaloi I've addressed the formatting issue, and made a note for future contributors to do the same.

[robertoaloi]

@robertoaloi I've addressed the formatting issue, and made a note for future contributors to do the same.

Thanks! CI actually has that step, but:

1. It needs approval to run on our side (you may need to enable actions on your fork to get earlier feedback)
2. I think it's misconfigured to only work on push and not on pull requests (should be easy to solve)

[facebook-github-bot]

@robertoaloi has imported this pull request. If you are a Meta employee, you can view this in D80779500.

[facebook-github-bot]

@robertoaloi merged this pull request in 0809b9c.