-
Notifications
You must be signed in to change notification settings - Fork 47
windows initial support #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @ZeeWanderer! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
|
|
Well, i still get... any ideas? |
|
Ok now linting sort of works. |
|
OTP 28 is now generally availalbe, so compiling edb for windows is trivial now. I did have some problems with erlfmt plugin, rebar3 would simply hang after downloading it or getting it from cache. Removing that escriptized smoothly. With this PR, if you do accept it, ELP now compiles for windows and is capable of using rebar3 without any trouble. Adding a windows pipeline would then be simple right? |
|
I have a really strange issue with |
|
@ZeeWanderer can you run |
|
Thanks for formatting. I think it makes sense to land this as a step in the right direction, and then start focusing on getting the github CI to run windows as well, based on it. I am also making some changes internally to document the need for |
Summary: Given preliminary Windows support was introduced via #111, it sounds reasonable to add a Windows pipeline to CI. Tests are currently omitted, since failing. The next step would be to figure out why. The pipeline could use some refactoring, which can be done separately. Reviewed By: TD5 Differential Revision: D80716715 fbshipit-source-id: c07eb94e94efa2079880c0507e255ec659a1904d
This makes it compile on Windows and work from the command line, but still can't get it to work properly with Windows VS Code extension.
and when runningTurns outelp shellwatchmanwas not installed. Haven't seen it in setup docs.build_info.json and project_imfo.json for the newly generated rebar3 project
#26