Skip to content

Task completed#10

Open
Nemehimself wants to merge 4 commits intoWeeshr-Engineering:mainfrom
Nemehimself:main
Open

Task completed#10
Nemehimself wants to merge 4 commits intoWeeshr-Engineering:mainfrom
Nemehimself:main

Conversation

@Nemehimself
Copy link
Copy Markdown

No description provided.

Comment thread src/utilities/books.ts
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of ChatGPT

Copy link
Copy Markdown
Collaborator

@codeDeeAi codeDeeAi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pass

  1. Node, TS
  2. Model Relationship
  3. Auth
  4. Proper use of env
  5. Error response, however a API response helper may be used to better structure the responses

Fail

  1. Request Validation
  2. APIs should be versioned
  3. No tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants