wasi:[email protected]: Add tests for flags/type APIs #131
Conversation
wingo
force-pushed
the
filesystem-flags-and-type
branch
from
5646b22 to
462f43f
Compare
wingo
force-pushed
the
filesystem-flags-and-type
branch
2 times, most recently
from
5cb924f to
298070d
Compare
|
Hi, I have 20 or so tests that are of this general form, so if it works for y'all @pchickey and @alexcrichton would you mind taking a look that there's nothing in this PR that you wouldn't want repeated 20 times ? All the branches share the commit that adds a |
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
Looks reasonable to me!
pchickey
left a comment
pchickey
left a comment
There was a problem hiding this comment.
Only one suggestion from me, maybe you already thought of this and there is a good reason it doesn't work.
| "wasi:cli/[email protected]#run", | ||
| ], | ||
| generate_all | ||
| }); |
There was a problem hiding this comment.
Can we use wit-bindgen somewhere common (e.g. src/lib.rs) rather than having invocations in each test? That will make it easier to update version numbers, and also hopefully save compile time.
There was a problem hiding this comment.
I looked into this and it got very annoying 😅
- If the mod is in
src/liblike in wasmtime's test-programs then I have to have the package name at all the use sites; annoying - The macrology needed to support multiple worlds is a bit annoying
- In general I was hoping for short & sweet & minimal
wit_bindgenworlds in each test; if we got it down to a couple lines, I think that would be a nice happy medium
All that said, I am sympathetic to the question of updating versions in umpteen places and of compile time. Let's revisit this. Happy to learn about tasteful ways to make things terse with Rust, I am still quite the newb!
wingo
force-pushed
the
filesystem-flags-and-type
branch
from
298070d to
a9bb5a4
Compare
wingo
changed the title
3 participants
No description provided.