[p3] Rename wasi:cli/std{out,err}#set-std{out,err}
#80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use "append" instead of "set" to help indicate that the output of the stream is appended to stdout/stderr as opposed to only one stream being read at a time.
Member
|
Could you also add a basic summary of what these functions do in documentation comments? |
Contributor
Author
|
Sure! |
sunfishcode
reviewed
Sep 8, 2025
|
|
||
| @since(version = 0.3.0-rc-2025-08-15) | ||
| interface stdout { | ||
| /// Appends the provided stream of data to the "stdout" of this component. |
Member
There was a problem hiding this comment.
What does "append" mean in this context? If an application calls append-stdout multiple times, how do the different output streams relate?
Contributor
Author
There was a problem hiding this comment.
Sure yeah, I've expanded the docs a bit
Contributor
Author
|
This was folded into #82 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use "append" instead of "set" to help indicate that the output of the stream is appended to stdout/stderr as opposed to only one stream being read at a time.