Skip to content
This repository was archived by the owner on Apr 25, 2025. It is now read-only.

Conversation

@ejrgilbert
Copy link
Contributor

No description provided.

@tlively
Copy link
Member

tlively commented Oct 25, 2024

Looks right, but curious that the tests weren't previously failing.

@jakobkummerow
Copy link
Contributor

curious that the tests weren't previously failing.

i31.get_s and i31.get_u both trap on (ref.null i31), so this doesn't affect test results.

Copy link
Contributor

@jakobkummerow jakobkummerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlively
Copy link
Member

tlively commented Oct 25, 2024

Ah, I misread and though that this function was used to test non-null cases.

@tlively tlively merged commit 1f803e1 into WebAssembly:main Oct 25, 2024
1 check passed
@ejrgilbert ejrgilbert deleted the patch-1 branch October 29, 2024 13:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants