forked from MetaMask/metamask-extension
-
Notifications
You must be signed in to change notification settings - Fork 0
Chore/segment onboarding #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
huggingbot
wants to merge
18
commits into
chore/sentry-onboarding
Choose a base branch
from
chore/segment-onboarding
base: chore/sentry-onboarding
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
b082933
chore: Update wallet setup started event
huggingbot 9867979
chore: Update wallet setup/import started/attempted/completed/failed …
huggingbot e98e9ef
feat: Enable event buffering and flushing to MetaMetrics
huggingbot 17e574a
feat: Add tracking for "Learn More" link in create password flow
huggingbot 12f57aa
fix: Incorrect property placement
huggingbot b56171b
feat: Add tracking for SRP definition clicks in onboarding flow
huggingbot 22012bd
feat: Add wallet login tracking events in onboarding flow
huggingbot 2c55aa8
feat: Add wallet rehydration tracking events for social login flow
huggingbot ecc033e
feat: Track password change events in security settings
huggingbot 5731900
feat: Add tracking for Forgot Password and Reset Wallet events in unl…
huggingbot ee01b5f
fix: Include account_type in WalletSetupCompleted
huggingbot 094b8cb
feat: Implement password strength evaluation in WalletCreated event
huggingbot 86de9ab
feat: Include account_type in WalletCreationAttempted
huggingbot 43420a5
refactor: Update wallet login events
huggingbot 9dd795c
refactor: Track social logins for new and existing users
huggingbot 0ecff9f
refactor: Rename wallet rehydration events to rehydration password ev…
huggingbot 5bdc817
feat: Track failed login attempts in unlock page events
huggingbot 76ed378
feat: Include actionId in buffered events for MetaMetrics
huggingbot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -700,23 +700,21 @@ export enum MetaMetricsEventName { | |
| NavSwapButtonClicked = 'Swap Button Clicked', | ||
| NavReceiveButtonClicked = 'Receive Button Clicked', | ||
| NftAdded = 'NFT Added', | ||
| OnboardingWalletCreationStarted = 'Wallet Setup Selected', | ||
| OnboardingWalletImportStarted = 'Wallet Import Started', | ||
| OnboardingWalletCreationAttempted = 'Wallet Password Created', | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These are unused or replaced with |
||
| OnboardingWalletSecurityStarted = 'SRP Backup Selected', | ||
| OnboardingWalletSecuritySkipInitiated = 'SRP Skip Backup Selected', | ||
| OnboardingWalletSecuritySkipConfirmed = 'SRP Backup Skipped', | ||
| OnboardingWalletSecuritySkipCanceled = 'SRP Skip Backup Canceled', | ||
| OnboardingWalletSecurityPhraseRevealed = 'SRP Revealed', | ||
| OnboardingWalletSecurityPhraseWrittenDown = 'SRP Backup Confirm Display', | ||
| OnboardingWalletSecurityPhraseConfirmed = 'SRP Backup Confirmed', | ||
| OnboardingWalletCreationComplete = 'Wallet Created', | ||
| OnboardingWalletCreationComplete = 'Onboarding Wallet Created', | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. there is already a |
||
| OnboardingWalletAdvancedSettings = 'Settings Updated', | ||
| OnboardingWalletImportAttempted = 'Wallet Import Attempted', | ||
| OnboardingWalletVideoPlay = 'SRP Intro Video Played', | ||
| OnboardingTwitterClick = 'External Link Clicked', | ||
| OnboardingWalletSetupComplete = 'Wallet Setup Complete', | ||
| OnrampProviderSelected = 'On-ramp Provider Selected', | ||
| PasswordChanged = 'Password Changed', | ||
| ForgotPassword = 'Forgot Password', | ||
| ResetWallet = 'Reset Wallet', | ||
| PermissionsApproved = 'Permissions Approved', | ||
| PermissionsRejected = 'Permissions Rejected', | ||
| PermissionsRequested = 'Permissions Requested', | ||
|
|
@@ -759,6 +757,7 @@ export enum MetaMetricsEventName { | |
| SrpViewSrpText = 'Views SRP', | ||
| SrpCopiedToClipboard = 'Copies SRP to clipboard', | ||
| SrpToConfirmBackup = 'SRP Backup Confirm Displayed', | ||
| SrpDefinitionClicked = 'SRP Definition Clicked', | ||
| StakingEntryPointClicked = 'Stake Button Clicked', | ||
| SurveyToast = 'Survey Toast', | ||
| SupportLinkClicked = 'Support Link Clicked', | ||
|
|
@@ -776,10 +775,19 @@ export enum MetaMetricsEventName { | |
| TokenImportCanceled = 'Token Import Canceled', | ||
| TokenImportClicked = 'Token Import Clicked', | ||
| ShowNativeTokenAsMainBalance = 'Show native token as main balance', | ||
| WalletSetupStarted = 'Wallet Setup Selected', | ||
| WalletSetupCanceled = 'Wallet Setup Canceled', | ||
| WalletSetupFailed = 'Wallet Setup Failed', | ||
| WalletSetupStarted = 'Wallet Setup Started', | ||
| WalletImportStarted = 'Wallet Import Started', | ||
| WalletImportAttempted = 'Wallet Import Attempted', | ||
| WalletImported = 'Wallet Imported', | ||
| WalletCreationAttempted = 'Wallet Creation Attempted', | ||
| WalletCreated = 'Wallet Created', | ||
| WalletSetupFailure = 'Wallet Setup Failure', | ||
| WalletSetupCompleted = 'Wallet Setup Completed', | ||
| WalletRehydrationSelected = 'Wallet Rehydration Selected', | ||
| SocialLoginCompleted = 'Social Login Completed', | ||
| RehydrationPasswordAttempted = 'Rehydration Password Attempted', | ||
| RehydrationPasswordCompleted = 'Rehydration Password Completed', | ||
| RehydrationPasswordFailed = 'Rehydration Password Failed', | ||
| // BEGIN:ONLY_INCLUDE_IF(build-flask) | ||
| WatchEthereumAccountsToggled = 'Watch Ethereum Accounts Toggled', | ||
| // END:ONLY_INCLUDE_IF | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're just exposing an existing implementation. Not sure why it wasn't exposed. These methods were unused and were probably removed previously, though the implementations were kept