Skip to content

Conversation

@lwin-kyaw
Copy link

@lwin-kyaw lwin-kyaw commented May 12, 2025

Description

Added Change Password feature for SRP flow and Social Login flow.

  • for the SRP flow, changing password will only change the vault password in the current device
  • for the Social Login flow, changing password will affect the multiple devices under the same social login.

Open in GitHub Codespaces

Manual testing steps

  1. Go to Security & Privacy tab in the settings
  2. Click Change Password
  3. Enter the current password first to verify as a valid user
  4. Enter new password

Screenshots/Recordings

Before

After

change-password.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link

github-actions bot commented May 12, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

path={SECURITY_PASSWORD_CHANGE_ROUTE}
component={ChangePassword}
/>
<Route exact path={REVEAL_SRP_LIST_ROUTE} component={RevealSrpList} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed here, be17505

@chaitanyapotti chaitanyapotti marked this pull request as ready for review May 23, 2025 10:00
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lwin-kyaw lwin-kyaw changed the title feat: change password of the wallets created with Social Account feat: wallet settings with social login and change password May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants