Ask q#5
Merged
Merged
Conversation
… thread - Wrap run_worker call in closure and schedule via call_from_thread in _on_question_asked - Add thread-safety for question.asked event handler when invoked from tool executor thread - Add defensive exception logging when worker scheduling fails - Update docstring to explain call_from_thread + run_worker pattern for cross-thread event handling
- Remove QuestionScreen modal and replace with inline AskQuestionWidget in main app layout - Add AskQuestionWidget to app composition and cache reference in _w_ask_question - Replace push_screen_wait flow with _ask_inline_question using asyncio.Queue for answer collection - Add _show_question_widget/_restore_input to toggle between InputBox and AskQuestionWidget - Add on_ask_question_widget_answered handler to receive answers via
- Bump textual to >=8.0.1 for improved focus behavior - Add RuntimeError fallback in _on_question_asked when call_from_thread fails on app loop - Add asyncio.CancelledError handling in _run_question_sequence with debug logging - Pad all_answers list when sequence is cancelled to match question count - Replace direct focus() with call_after_refresh + defensive focus chain in _show_question_widget - Try OptionList focus first
- Add centered header with badges for Python, Ollama, license, stars, and issues - Replace plain text sections with emoji-prefixed headings throughout - Add visual comparison table with emoji icons for feature categories - Add note/tip/important callouts using GitHub-flavored markdown admonitions - Reorganize table of contents with emoji prefixes and flattened structure - Add numbered step headings in Quick Start section - Add Contributing
- Add WARNING admonition above table of contents with experimental status notice - Warn users about potential bugs, incomplete features, and breaking changes - Advise caution when using file modification tools and recommend reviewing changes - Emphasize importance of maintaining backups of important data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.