xwayland: offer focus in global active cases #2780
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Relate: |
ssfdust
force-pushed
the
fix_wechat_popup
branch
2 times, most recently
from
549ec8e to
b5576f1
Compare
ammen99
reviewed
Aug 20, 2025
Not all diglogs want focus though they are focusable. In some strange cases, (e.g. WeChat, a famous chat application in China), the application's popup has both NORMAL and UTILITY type, we need to call wlr_xwayland_surface_offer_focus() for these views, in case they actually don't want focus.
ssfdust
force-pushed
the
fix_wechat_popup
branch
from
b5576f1 to
54f36c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all diglogs want focus though they are focusable. In some strange cases, (e.g. WeChat, a famous chat application in China), the application's popup has both NORMAL and UTILITY type, we need to call wlr_xwayland_surface_offer_focus() for these views, in case they actually don't want focus.