fix(cli-sdk): fix swidge session mismatch and relay error crash#40
Merged
Conversation
…ay errors 1. Only include fromChain in session namespaces — bridge tx is sent on the source chain, so including toChain caused NO_MATCHING_KEY when restoring sessions without the destination chain approved. 2. Capture relay errors during request() so wallet rejection/timeout doesn't crash Node with an unhandled 'error' event. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fromChainin session namespaces — the bridge tx is sent on the source chain, so includingtoChaincausedNO_MATCHING_KEYwhen restoring sessions that didn't have the destination chain approvedrequest()so wallet rejection/timeout doesn't crash Node with an unhandled'error'event (matches existing pattern indisconnect())Test plan
npm run build— all packages buildnpm run test— all 107 tests passwalletconnect swidgewith a cross-chain bridge, verify session restore works🤖 Generated with Claude Code