fix(staking-cli): truncate balance display instead of rounding up#34
Merged
Conversation
formatWCT used toLocaleString rounding, which could display a value higher than the actual on-chain balance (e.g. 112.89 instead of 112.88). Users copying the displayed balance into `stake` would get ERC20InsufficientBalance reverts. Now truncates to 2 decimal places. Also adds a pre-flight balance check in `stake` before the approve tx to avoid wasting gas when the amount exceeds the actual balance. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
formatWCTrounding bug: Truncates to 2 decimal places instead of rounding, so the displayed balance is never higher than the actual on-chain balance (e.g. shows112.88instead of112.89for112.887964...WCT)stake: Checks on-chain balance before sending the approve tx, preventing wasted gas when the requested amount exceeds the actual balance.999edge caseFixes: balance display rounds up, causing
stakewith displayed full balance to always revert withERC20InsufficientBalance.Test plan
balanceand verify displayed value is ≤ actual on-chain balancestakewith amount exceeding balance and verify early error (no approve tx sent)🤖 Generated with Claude Code