Bound startup retry loop and add SKIP_STARTUP_CHECKS env flag#10
Draft
Copilot wants to merge 2 commits intohawki_improvementsfrom
Draft
Bound startup retry loop and add SKIP_STARTUP_CHECKS env flag#10Copilot wants to merge 2 commits intohawki_improvementsfrom
Copilot wants to merge 2 commits intohawki_improvementsfrom
Conversation
Merged
Co-authored-by: dschiese <135758800+dschiese@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on Hawki improvements pull request
Bound startup retry loop and add SKIP_STARTUP_CHECKS env flag
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run_startup_checks()contained an unboundedwhileretry loop — if Hawki was unreachable orALLOWED_KEYSwas misconfigured, the app would hang indefinitely, blockingTestClient-based tests and production startup alike.Changes
SKIP_STARTUP_CHECKS(default:false): Bypasses all startup checks whentrue. Background cleanup task is still scheduled. Intended for test/dev environments.STARTUP_MAX_RETRIES(default:0= unlimited): Caps the Hawki endpoint retry loop. On exhaustion, logs an error and returns — service continues in degraded state rather than blocking forever.STARTUP_MAX_RETRIESvalue raises aValueErrorwith a descriptive message at startup.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.