Skip to content

Respect 'regions' kwarg for 2D Makie scalarplots #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pjaap
Copy link
Member

@pjaap pjaap commented Jun 25, 2025

This is WIP.

I want to pass the regions kwarg to the Makie backend.

To do this, I simply push only triangles into the list, that correspond to the region numbers.

Additionally, I want the colorbar to be fitted to the values on the desired regions. Therefore, I introduced :fit for limits to compute the extrema on that regions.

@j-fu

  • Is this approach going in the right direction?
  • how to compute the limits more efficiently?

TODOS:

  • also for 1D/3D scalarplots
  • CHANGELOG
  • DOC (for :fit)
  • ...

@pjaap pjaap marked this pull request as draft June 25, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant