Respect 'regions' kwarg for 2D Makie scalarplots #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is WIP.
I want to pass the
regions
kwarg to theMakie
backend.To do this, I simply push only triangles into the list, that correspond to the region numbers.
Additionally, I want the colorbar to be fitted to the values on the desired regions. Therefore, I introduced
:fit
forlimits
to compute the extrema on that regions.@j-fu
TODOS:
:fit
)