Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
railway-app
Bot
temporarily deployed
to
volvox-bot / volvox-bot-pr-335
|
🚅 Deployed to the volvox-bot-pr-335 environment in volvox-bot
|
Contributor
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThis PR encompasses comprehensive updates across configuration, testing, and web dashboard UI. Changes include enabling Claude AI review in workflows, adding test cases for commands and event handlers, refactoring dashboard layout components, introducing CSS styling enhancements with new utility classes and animations, reorganizing UI component exports, and removing migration documentation. Changes
Possibly related PRs
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
BillChirico
force-pushed
the
claude/redesign-dashboard-ui-E8zzE
branch
from
79acfb4 to
e680453
Compare
railway-app
Bot
temporarily deployed
to
volvox-bot / volvox-bot-pr-335
BillChirico
force-pushed
the
claude/redesign-dashboard-ui-E8zzE
branch
from
e680453 to
d038feb
Compare
railway-app
Bot
temporarily deployed
to
volvox-bot / volvox-bot-pr-335
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates both the bot and web dashboard with expanded test coverage, UI refinements (new card/gradient styling and layout tweaks), dependency bumps (notably Turbo/Next/Tailwind/Biome), and a refined Claude review workflow trigger.
Changes:
- Add/extend Vitest coverage for prompts, event dispatching, and key commands (warn/welcome).
- Refresh dashboard UI styling (new glow/KPI card patterns, navigation polish) and minor config editor UX tweaks.
- Update tooling/dependencies and automation (Turbo/Next/Tailwind lockfiles, Biome schema, Claude review workflow triggers).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| web/tests/stores/members-store.test.ts | Fixes stale-request error test plumbing by capturing the reject callback directly. |
| web/tests/next.config.test.ts | Updates Next config import path and adds a typed header shape in the test. |
| web/src/hooks/use-glow-card.ts | Adds a client hook to drive CSS glow effects via pointer position. |
| web/src/components/ui/table.tsx | Reorders exports (no functional change). |
| web/src/components/ui/sheet.tsx | Reorders exports (no functional change). |
| web/src/components/ui/popover.tsx | Reorders exports (no functional change). |
| web/src/components/ui/form.tsx | Reorders exports (no functional change). |
| web/src/components/ui/error-boundary.tsx | Adjusts import ordering (no functional change). |
| web/src/components/ui/dropdown-menu.tsx | Reorders exports (no functional change). |
| web/src/components/ui/command.tsx | Reorders exports (no functional change). |
| web/src/components/ui/channel-selector.tsx | Adjusts export ordering (no functional change). |
| web/src/components/ui/card.tsx | Reorders exports (no functional change). |
| web/src/components/ui/avatar.tsx | Reorders exports (no functional change). |
| web/src/components/layout/sidebar.tsx | Sidebar UI refresh: active state, indicators, and call-to-action styling. |
| web/src/components/layout/server-selector.tsx | Minor formatting/markup tightening for dropdown label. |
| web/src/components/layout/header.tsx | Header UI refresh (logo mark, status indicator, user menu styling). |
| web/src/components/layout/dashboard-shell.tsx | Adjusts sidebar width and adds thin scrollbar styling. |
| web/src/components/landing/Footer.tsx | Normalizes JSX attribute quoting. |
| web/src/components/landing/FeatureGrid.tsx | Collapses simple JSX blocks (formatting-only change). |
| web/src/components/dashboard/types.ts | Formats multi-condition validation for readability. |
| web/src/components/dashboard/performance-dashboard.tsx | Import ordering adjustment for toast. |
| web/src/components/dashboard/page-header.tsx | Enhances header visuals (accent bar, shimmer, action container styling). |
| web/src/components/dashboard/log-viewer.tsx | Splits a long line for readability (no functional change). |
| web/src/components/dashboard/health-cards.tsx | KPI card styling enhancements and ping badge background helper. |
| web/src/components/dashboard/config-workspace/settings-feature-card.tsx | Reworks feature card markup/styling; adds enabled-state affordances. |
| web/src/components/dashboard/config-workspace/config-categories.ts | Condenses sectionKeys array formatting. |
| web/src/components/dashboard/config-workspace/category-navigation.tsx | Adds per-category icon tint styling + nav UI polish. |
| web/src/components/dashboard/config-sections/CommunitySettingsSection.tsx | Simplifies bot status rotation defaulting logic and formatting. |
| web/src/components/dashboard/config-layout-shell.tsx | Config editor top bar and status banner UX updates + styling tweaks. |
| web/src/components/dashboard/config-categories/config-landing.tsx | Redesigns category landing cards with gradients and “Configure” affordance. |
| web/src/components/dashboard/analytics-dashboard.tsx | Applies KPI/glow card styling and wires useGlowCard() for hover glow behavior. |
| web/src/app/page.tsx | Normalizes JSX attribute quoting in the landing page SVG. |
| web/src/app/globals.css | Adds new design tokens/utilities (glow/KPI/status/sidebar/settings cards, gradients, scrollbars). |
| web/src/app/dashboard/moderation/moderation-client.tsx | Refactors header/empty-state rendering and improves section layout styling. |
| web/src/app/dashboard/members/members-client.tsx | Refactors header/empty-state rendering; reorganizes error placement and layout. |
| web/src/app/dashboard/conversations/conversations-client.tsx | Refactors header/empty-state rendering; reorganizes filters/table/error blocks. |
| web/src/app/api/guilds/[guildId]/members/[userId]/xp/route.ts | Collapses a JSON error response to a single line (no behavior change). |
| web/pnpm-lock.yaml | Bumps web lockfile deps (Next 16.2.0, Tailwind 4.2.2, etc.). |
| web/next-env.d.ts | Updates the generated routes types import path under .next/. |
| tests/prompts/index.test.js | Adds prompt loading/path tests (with cache reset). |
| tests/modules/events/interactionCreate.test.js | Adds tests for interaction handler dispatch short-circuiting and error logging. |
| tests/modules/events.test.js | Adds regression test to skip welcome handling when welcome feature is disabled. |
| tests/commands/welcome.test.js | Adds onboarding panel posting coverage when configured channels are valid. |
| tests/commands/warn.test.js | Adds coverage ensuring default severity is low when omitted. |
| pnpm-lock.yaml | Bumps workspace lockfile Turbo entries to 2.8.20. |
| package.json | Bumps Turbo to ^2.8.20. |
| migrations/README.md | Removes migrations documentation file. |
| biome.json | Updates Biome schema version to 2.4.8. |
| .gitignore | Ignores .DS_Store. |
| .github/workflows/claude-review.yml | Enables workflow triggers on review/review-comment mentions of @claude, with bot-user filtering. |
| expect(disk.length).toBeGreaterThan(0); | ||
| }); | ||
| }); | ||
| ; |
There was a problem hiding this comment.
There is an extra standalone semicolon at the end of the file. This is a no-op but commonly triggers “no extra semicolons”/formatting rules and adds noise in diffs; removing it keeps the test file clean.
Suggested change
| ; |
Contributor
🧹 Preview Environment Cleaned UpThe Railway preview environment for this PR has been removed. Environment: |
|
| Filename | Overview |
|---|---|
| tests/commands/warn.test.js | Adds a single test verifying that the severity option defaults to 'low' when omitted. The test correctly overrides getString to return null for 'severity', mirrors the real command logic, and asserts against createWarning's call arguments. |
| tests/commands/welcome.test.js | Adds a new test covering the full happy path of the /welcome setup command (both panels posted). Mock wiring is correct; minor issue: safeSend assertions use exact mock shapes instead of objectContaining, making them fragile if mock defaults change. |
| tests/modules/events.test.js | Adds one test to verify that welcome handling is skipped when welcome.enabled is false. Aligns correctly with the gate in guildMemberAdd.js (line 21: if (!guildConfig.welcome?.enabled) return). |
| tests/modules/events/interactionCreate.test.js | New test file for registerComponentHandlers dispatch loop. Correctly uses vi.hoisted + vi.mock to intercept module-level handler references. Two tests cover the early-exit-on-handled and abort-on-error paths; the early-exit test could assert all downstream handlers are skipped for a more complete contract. |
| tests/prompts/index.test.js | New test file for the prompt loader. Integration-style tests read actual .md files from disk; all three placeholder variables (communityRules, conversationText, botUserId) are confirmed present in triage-classify.md. One minor issue: a stray trailing semicolon on the final line of the file. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[InteractionCreate event fires] --> B[Iterate handlers array]
B --> C{Call handler_n\ninteraction}
C -->|throws| D[logError with handler name\ncustomId, error message]
D --> E[return — abort dispatch]
C -->|returns true\nhandled| F[return — stop chain]
C -->|returns false\nnot handled| G{More handlers?}
G -->|yes| C
G -->|no| H[All handlers exhausted\nno-op]
subgraph handlers_array [handlers array — module scope]
direction LR
H1[handlePollButton]
H2[handleChallengeButton]
H3[handleReviewButton]
H4[handleShowcaseButton]
H5[handleShowcaseModal]
H6[handleTicketOpenButton]
H7[handleTicketModal]
H8[handleTicketCloseButton]
H9[handleReminderButton]
H10[handleWelcomeOnboarding]
end
Prompt To Fix All With AI
This is a comment left during a code review.
Path: tests/prompts/index.test.js
Line: 38
Comment:
**Stray trailing semicolon**
There is a lone `;` after the closing `});` of the `describe` block. This is a no-op statement and is almost certainly a copy-paste typo. It should be removed to keep the file clean and avoid Biome linting warnings.
```suggestion
});
```
How can I resolve this? If you propose a fix, please make it concise.
---
This is a comment left during a code review.
Path: tests/commands/welcome.test.js
Line: 128-129
Comment:
**Assertions test mock contract, not real message shape**
Both assertions check that `safeSend` is called with exactly `{ content: 'rules' }` and `{ content: 'roles' }`. These shapes come from the mocks of `buildRulesAgreementMessage` / `buildRoleMenuMessage`, not from the real implementations. The real functions return richer objects containing `components: [row]` as well.
If the intent is to verify that the correct channel and message object get forwarded (i.e. that the result of the builder is passed through unchanged), using `expect.objectContaining({ content: 'rules' })` would make the test resilient to changes in the mock contract while still capturing the intent:
```suggestion
expect(safeSend).toHaveBeenNthCalledWith(1, rulesChannel, expect.objectContaining({ content: 'rules' }));
expect(safeSend).toHaveBeenNthCalledWith(2, welcomeChannel, expect.objectContaining({ content: 'roles' }));
```
How can I resolve this? If you propose a fix, please make it concise.
---
This is a comment left during a code review.
Path: tests/modules/events/interactionCreate.test.js
Line: 62-80
Comment:
**Test verifies early-exit but doesn't assert all skipped handlers**
The test confirms that `handleReviewButton` (the third handler) is not called once `handleChallengeButton` returns `true`, but it doesn't assert that the remaining handlers (`handleShowcaseButton`, `handleShowcaseModal`, `handleTicketOpenButton`, etc.) are also skipped. If the dispatch loop ever gains a `continue` instead of `return`, downstream handlers would still fire unexpectedly.
Consider adding assertions for the remaining handlers to make the contract explicit:
```js
expect(handleShowcaseButton).not.toHaveBeenCalled();
expect(handleTicketOpenButton).not.toHaveBeenCalled();
expect(handleReminderButton).not.toHaveBeenCalled();
```
How can I resolve this? If you propose a fix, please make it concise.Last reviewed commit: "test: raise coverage..."
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and updates across the codebase, focusing on enhanced test coverage, dependency updates, and workflow refinements. The most significant changes include new and expanded test cases for core modules and commands, updates to key dependencies (notably
turbo,next, andtailwindcss), and an improved GitHub Actions workflow for code review automation.Testing improvements:
registerComponentHandlerslogic ininteractionCreateto ensure handlers are called and errors are logged as expected (tests/modules/events/interactionCreate.test.js).warncommand to verify default severity behavior, and for thewelcomecommand to cover posting onboarding panels when channels are valid (tests/commands/warn.test.js,tests/commands/welcome.test.js) [1] [2].tests/modules/events.test.js).tests/prompts/index.test.js).Dependency and toolchain updates:
turbofrom version 2.8.19 to 2.8.20 inpackage.jsonand all corresponding lockfile entries (pnpm-lock.yaml) [1] [2] [3] [4] [5] [6].nextfrom 16.1.7 to 16.2.0 andtailwindcss(and@tailwindcss/postcss) from 4.2.1 to 4.2.2 in the web app lockfile (web/pnpm-lock.yaml) [1] [2] [3].biome.jsonfrom 2.4.7 to 2.4.8.Workflow and documentation:
.github/workflows/claude-review.ymlto trigger on pull request review comments and reviews mentioning@claude, and to ignore bot users, improving automation and reducing noise.migrations/README.mdfile, as it is no longer needed or relevant.These changes collectively improve the project's reliability, maintainability, and developer experience.