Skip to content

Let rabbits join the fun!#13

Merged
VoidLeech merged 6 commits into
VoidLeech:mc1.20.1/forge/devfrom
Allmoz:mc1.20.1/forge/dev
Apr 28, 2026
Merged

Let rabbits join the fun!#13
VoidLeech merged 6 commits into
VoidLeech:mc1.20.1/forge/devfrom
Allmoz:mc1.20.1/forge/dev

Conversation

@Allmoz
Copy link
Copy Markdown
Contributor

@Allmoz Allmoz commented Apr 27, 2026

I was making this mixing for another mod, but i suppose here can find a better home
{2F3B5B24-AAC7-4479-9B16-22A1E69BF0F6}

I had made an issue to ask, but github is misbehaving so bad I don't if is there, i will link it once the issues page opens again

@Allmoz
Copy link
Copy Markdown
Contributor Author

Allmoz commented Apr 27, 2026

(i did just add the files to show, if is wanted i can properly test it)

@Allmoz Allmoz marked this pull request as draft April 27, 2026 19:05
Copy link
Copy Markdown
Owner

@VoidLeech VoidLeech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting and generally looks good. See also my comment on #12 but I'd be happy to merge this earlier (:

Please prefix all mixin methods with create_repair$ and add the mixins to the mixins.json.

Comment thread src/main/java/ch/voidlee/repair/mixin/tweaks/MixinCreateHatArmorLayer.java Outdated
Comment thread src/main/java/ch/voidlee/repair/mixin/tweaks/MixinCreateHatArmorLayer.java Outdated
Comment thread src/main/java/ch/voidlee/repair/mixin/tweaks/MixinCreateHatArmorLayer.java Outdated
Comment thread src/main/java/ch/voidlee/repair/mixin/tweaks/MixinCreateHatArmorLayer.java Outdated
@VoidLeech VoidLeech linked an issue Apr 27, 2026 that may be closed by this pull request
@Allmoz
Copy link
Copy Markdown
Contributor Author

Allmoz commented Apr 27, 2026

Creators-of-Create/Create#10248 :) one done

@Allmoz Allmoz force-pushed the mc1.20.1/forge/dev branch from eee3379 to ce6e263 Compare April 27, 2026 20:48
@Allmoz
Copy link
Copy Markdown
Contributor Author

Allmoz commented Apr 27, 2026

the gradle project is not importing yet, so i pushed it, the only doubt i have is if is ok to have both of the mixin only on the client

@Allmoz Allmoz marked this pull request as ready for review April 27, 2026 20:53
@Allmoz Allmoz requested a review from VoidLeech April 27, 2026 20:55
@VoidLeech
Copy link
Copy Markdown
Owner

Ah, didn't catch that. Those mixins should be moved into (new) respective packages under the mixin.client package.

@Allmoz
Copy link
Copy Markdown
Contributor Author

Allmoz commented Apr 27, 2026

are those packages names and the remaps ok?

Copy link
Copy Markdown
Owner

@VoidLeech VoidLeech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We all overlook things XD; some small things but otherwise looks good to merge.

Comment thread src/main/java/ch/voidlee/repair/mixin/client/tweaks/CreateHatArmorLayerMixin.java Outdated
Comment thread src/main/java/ch/voidlee/repair/mixin/client/tweaks/CreateHatArmorLayerMixin.java Outdated
@VoidLeech VoidLeech merged commit 7b3974f into VoidLeech:mc1.20.1/forge/dev Apr 28, 2026
@VoidLeech
Copy link
Copy Markdown
Owner

Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rabbit Hats?

2 participants