Skip to content

[k2] adapt array functions - #1362

Merged
PetrShumilov merged 18 commits into
masterfrom
pshumilov/k2_array_functions
Jul 20, 2025
Merged

[k2] adapt array functions#1362
PetrShumilov merged 18 commits into
masterfrom
pshumilov/k2_array_functions

Conversation

@PetrShumilov

@PetrShumilov PetrShumilov commented Jul 7, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Goals:

  • Move functions into common code wherever possible
  • Refactor methods where the parameter can be coroutine
  • Enable tests that were previously skipped for k2

@PetrShumilov PetrShumilov added this to the next milestone Jul 7, 2025
@PetrShumilov PetrShumilov self-assigned this Jul 7, 2025
@PetrShumilov PetrShumilov added the k2 Affects compiler or runtime in K2 mode label Jul 7, 2025
@PetrShumilov
PetrShumilov force-pushed the pshumilov/k2_array_functions branch 2 times, most recently from 39a72c0 to 9eba117 Compare July 9, 2025 13:58
@PetrShumilov
Move array_pad to common
4c5b1af 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
Implement array_find
ca2c4e3 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
PetrShumilov force-pushed the pshumilov/k2_array_functions branch from 9eba117 to ca2c4e3 Compare July 9, 2025 14:14
@PetrShumilov
Move getKeyByPos and getValueByPos to common
94c506f 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
Move create_vector to common
3c26fbe 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
PetrShumilov force-pushed the pshumilov/k2_array_functions branch from 73a948e to 3c26fbe Compare July 14, 2025 11:06
@PetrShumilov
Move array_swap_int_keys to common
786fff8 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
Move array_splice to common
d56bddc 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
PetrShumilov force-pushed the pshumilov/k2_array_functions branch 3 times, most recently from ff1f777 to 9136353 Compare July 14, 2025 12:55
@PetrShumilov
Move array_merge_spread to common
b778780 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
Move array_merge_recursive to common
9b88e98 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
Move array_intersect_assoc to common
2dda797 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
PetrShumilov force-pushed the pshumilov/k2_array_functions branch from 9136353 to 2dda797 Compare July 14, 2025 13:13
@PetrShumilov
Move array_fill_keys to common
27d5191 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
Move array_diff_key to common
c264e17 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
Move array_diff_assoc to common
0bb4ec3 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
Move array_count_values to common
6907a10 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
Move array_combine to common
03a492f 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
Move array_column to common
76efcc2 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
astrophysik
astrophysik reviewed Jul 16, 2025
View reviewed changes
Comment thread builtin-functions/kphp-light/stdlib/array-functions.txt Outdated
Comment thread runtime-common/stdlib/array/array-functions.h Outdated
Comment thread runtime-common/stdlib/array/array-functions.h Outdated
apolyakov
apolyakov requested changes Jul 16, 2025
View reviewed changes
Comment thread runtime-light/stdlib/array/array-functions.h
Comment thread runtime-light/stdlib/array/array-functions.h Outdated
@PetrShumilov
Remove useless anno @kphp-extern-func-info with empty attribute list
515c109 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
Add explicit tuple header
df991f3 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
PetrShumilov force-pushed the pshumilov/k2_array_functions branch 2 times, most recently from db5b318 to b168949 Compare July 16, 2025 15:25
apolyakov
apolyakov requested changes Jul 16, 2025
View reviewed changes
Comment thread runtime-light/stdlib/array/array-functions.h Outdated
@PetrShumilov
PetrShumilov force-pushed the pshumilov/k2_array_functions branch from b168949 to c562591 Compare July 17, 2025 11:00
@PetrShumilov
Add missing noexcept modifier
8e33d92 
Signed-off-by: Petr Shumilov <p.shumilov@vkteam.ru>
@PetrShumilov
PetrShumilov force-pushed the pshumilov/k2_array_functions branch from c562591 to 8e33d92 Compare July 17, 2025 11:01
@PetrShumilov
PetrShumilov merged commit 28f4f42 into master Jul 20, 2025
7 checks passed
@PetrShumilov
PetrShumilov deleted the pshumilov/k2_array_functions branch July 20, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apolyakov apolyakov apolyakov approved these changes
+1 more reviewer
@astrophysik astrophysik astrophysik approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@PetrShumilov PetrShumilov

Labels

k2 Affects compiler or runtime in K2 mode

Projects

None yet

Milestone

06.08.2025

Development

Successfully merging this pull request may close these issues.

3 participants

@PetrShumilov @apolyakov @astrophysik