Skip to content

feat: add CustomScrollView.Tint - #9359

Open
SevereCloud wants to merge 3 commits into
masterfrom
SevereCloud/feat/add-CustomScrollView.Tint
Open

feat: add CustomScrollView.Tint#9359
SevereCloud wants to merge 3 commits into
masterfrom
SevereCloud/feat/add-CustomScrollView.Tint

Conversation

@SevereCloud

@SevereCloud SevereCloud commented Jan 16, 2026 •
edited by d-suvorov-vk-team
Loading

Copy link
Copy Markdown
Contributor
  • Unit-тесты
  • e2e-тесты
  • Дизайн-ревью
  • Документация фичи
  • Release notes

Описание

Добавляем хук для создания теней к прокручиваемой области

Release notes

Новые компоненты

  • useCustomScrollViewTint: Хук для добавления теней к краям прокручиваемой области

@SevereCloud
SevereCloud requested a review from a team as a code owner January 16, 2026 11:30
@SevereCloud SevereCloud added this to VKUI Jan 16, 2026
@SevereCloud SevereCloud added this to the v8.1.0 milestone Jan 16, 2026
@SevereCloud
SevereCloud force-pushed the SevereCloud/feat/add-CustomScrollView.Tint branch from a85a9af to 886c55f Compare January 16, 2026 11:32
@github-actions

github-actions Bot commented Jan 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
JS 426.07 KB (+0.18% 🔺)
JS (gzip) 131.45 KB (+0.22% 🔺)
JS (brotli) 108.48 KB (+0.08% 🔺)
JS import Div (tree shaking) 945 B (0%)
CSS 382.76 KB (0%)
CSS (gzip) 46.81 KB (0%)
CSS (brotli) 36.96 KB (0%)

@github-actions

github-actions Bot commented Jan 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

e2e tests

Playwright Report

@github-actions

github-actions Bot commented Jan 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

📊 Найдены изменения в собранных файлах: Отчет

Commit c3f2c9e

@github-actions

github-actions Bot commented Jan 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

👀 Docs deployed

📦 Package ✅

yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/9359/c3f2c9e4233aa3e5443dfcd454f582a287f9fa5e/pkg/@vkontakte/vkui/_pkg.tgz

Commit c3f2c9e

@codecov

codecov Bot commented Jan 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.07843% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.23%. Comparing base (de1ce65) to head (4767acd).

Files with missing lines Patch % Lines
.../CustomScrollView/Tint/useCustomScrollViewTint.tsx 96.55% 1 Missing ⚠️
packages/vkui/src/hooks/useResizeObserver.ts 95.45% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #9359   +/-   ##
=======================================
  Coverage   95.23%   95.23%           
=======================================
  Files         460      461    +1     
  Lines       12519    12570   +51     
  Branches     4482     4490    +8     
=======================================
+ Hits        11922    11971   +49     
- Misses        597      599    +2
Flag Coverage Δ
unittests 95.23% <96.07%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

EldarMuhamethanov
EldarMuhamethanov reviewed Jan 16, 2026
View reviewed changes

@EldarMuhamethanov EldarMuhamethanov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread packages/vkui/src/components/CustomScrollView/Tint/CustomScrollViewTint.tsx Outdated
Comment thread packages/vkui/src/components/CustomScrollView/Tint/useCustomScrollViewTint.tsx
Comment thread packages/vkui/src/components/CustomScrollView/Tint/CustomScrollViewTint.tsx Outdated
@SevereCloud
SevereCloud force-pushed the SevereCloud/feat/add-CustomScrollView.Tint branch 2 times, most recently from 698fda9 to 021b56a Compare January 16, 2026 14:47
@vkcom-publisher vkcom-publisher added pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Jan 24, 2026
@vkcom-publisher vkcom-publisher added pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Feb 1, 2026
@vkcom-publisher vkcom-publisher added pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Feb 9, 2026
@vkcom-publisher vkcom-publisher added pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Feb 18, 2026
@vkcom-publisher vkcom-publisher added pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности and removed pr-needs-work Автоматизация: PR автоматически закроется через 14 дней при отсутствии активности labels Feb 26, 2026
@SevereCloud SevereCloud added type:feature cmp:custom-scroll-view no-stale Добавляет PR в исключения для автоматического закрытия labels Mar 3, 2026
@SevereCloud SevereCloud self-assigned this Mar 3, 2026
@SevereCloud SevereCloud moved this to 🔧 In progress in VKUI Mar 3, 2026
@inomdzhon inomdzhon modified the milestones: v8.1.0, v8.2.0 Apr 13, 2026
@inomdzhon inomdzhon removed this from the v8.2.0 milestone May 15, 2026
@inomdzhon inomdzhon added this to the v8.3.0 milestone May 15, 2026
@inomdzhon inomdzhon modified the milestones: v8.3.0, v8.4.0 Jun 22, 2026
@d-suvorov-vk-team
d-suvorov-vk-team force-pushed the SevereCloud/feat/add-CustomScrollView.Tint branch from ad82164 to 4b580a7 Compare August 10, 2026 12:45
d-suvorov-vk-team
d-suvorov-vk-team reviewed Aug 12, 2026
View reviewed changes
Comment thread packages/vkui/src/components/CustomScrollView/Tint/useCustomScrollViewTint.tsx Outdated
@d-suvorov-vk-team
Apply suggestions from code review
c3f2c9e 
Co-authored-by: d-suvorov-vk-team <d.suvorov@vk.team>
@i-mirdzhamolov-vk-team

i-mirdzhamolov-vk-team commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Падают тесты( happy-dom?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d-suvorov-vk-team d-suvorov-vk-team d-suvorov-vk-team left review comments
@i-mirdzhamolov-vk-team i-mirdzhamolov-vk-team i-mirdzhamolov-vk-team approved these changes
+2 more reviewers
@inomdzhon inomdzhon inomdzhon left review comments
@EldarMuhamethanov EldarMuhamethanov EldarMuhamethanov left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@SevereCloud SevereCloud

Labels

cmp:custom-scroll-view no-stale Добавляет PR в исключения для автоматического закрытия type:feature

Projects

VKUI
Status: 🔧 In progress

Milestone

v8.4.0

Development

Successfully merging this pull request may close these issues.

6 participants

@SevereCloud @i-mirdzhamolov-vk-team @inomdzhon @EldarMuhamethanov @d-suvorov-vk-team @vkcom-publisher