feat(PullToRefresh): add Button for a11y - #10046
Open
SevereCloud wants to merge 2 commits into
Open
Conversation
Contributor
size-limit report 📦
|
Contributor
e2e tests |
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10046 +/- ##
=======================================
Coverage 95.21% 95.22%
=======================================
Files 461 461
Lines 12528 12535 +7
Branches 4485 4488 +3
=======================================
+ Hits 11929 11936 +7
Misses 599 599
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
👀 Docs deployed
📦 Package ✅yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/10046/d8a344389d5c873660d7cf0f5f9df48ac6127dfd/pkg/@vkontakte/vkui/_pkg.tgzCommit d8a3443 |
vkcom-publisher
added
the
pr-needs-work
inomdzhon
reviewed
Jul 21, 2026
i-mirdzhamolov-vk-team
left a comment
i-mirdzhamolov-vk-team
left a comment
Contributor
There was a problem hiding this comment.
В примере до загрузки контента кнопка по табу не появляется 🤔
2026-07-28.11.26.06.mov
d-suvorov-vk-team
force-pushed
the
SevereCloud/feat/PullToRefresh/add-Button-for-a11y
branch
from
July 30, 2026 08:24
b15a96e to
37e2b7d
Compare
i-mirdzhamolov-vk-team
previously approved these changes
Jul 30, 2026
d-suvorov-vk-team
force-pushed
the
SevereCloud/feat/PullToRefresh/add-Button-for-a11y
branch
from
July 30, 2026 09:16
37e2b7d to
28520ee
Compare
i-mirdzhamolov-vk-team
previously approved these changes
Jul 30, 2026
i-mirdzhamolov-vk-team
self-requested a review
July 30, 2026 09:57
i-mirdzhamolov-vk-team
left a comment
i-mirdzhamolov-vk-team
left a comment
Contributor
There was a problem hiding this comment.
тест упал
может быть связано с обновлением React до 19 32c75c5
vkcom-publisher
removed
the
pr-needs-work
d-suvorov-vk-team
force-pushed
the
SevereCloud/feat/PullToRefresh/add-Button-for-a11y
branch
from
August 5, 2026 14:16
28520ee to
937e934
Compare
d-suvorov-vk-team
force-pushed
the
SevereCloud/feat/PullToRefresh/add-Button-for-a11y
branch
from
August 10, 2026 07:55
937e934 to
d8a3443
Compare
i-mirdzhamolov-vk-team
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PullToRefresh#3048e2e-тестыОписание
PullToRefresh не доступен с клавиатуры и в дереве доступности
Изменения
Добавляем скрытую кнопку которая показывается только при фокусе
Release notes
Улучшения