feat(CustomSelect): shows clear button when typing in search - #10029
Open
SevereCloud wants to merge 1 commit into
Open
feat(CustomSelect): shows clear button when typing in search#10029SevereCloud wants to merge 1 commit into
SevereCloud wants to merge 1 commit into
Conversation
Contributor
size-limit report 📦
|
SevereCloud
force-pushed
the
SevereCloud/feat/shows-clear-button-when-typing-in-search
branch
from
July 6, 2026 11:12
6d41dde to
1d76d8f
Compare
Contributor
e2e tests |
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10029 +/- ##
==========================================
- Coverage 95.23% 95.22% -0.01%
==========================================
Files 462 462
Lines 12518 12685 +167
Branches 4479 4549 +70
==========================================
+ Hits 11921 12079 +158
- Misses 597 606 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
👀 Docs deployed
📦 Package ✅yarn add @vkontakte/vkui@https://development.s3.prodcloud.vk.team/pull/10029/1d76d8f8d11337d6b7016aff5d4ee6965caf894f/pkg/@vkontakte/vkui/_pkg.tgzCommit 1d76d8f |
vkcom-publisher
added
the
pr-needs-work
Contributor
|
PR закрыт из-за отсутствия активности в течение последних 14 дней. Если это произошло по ошибке или изменения все ещё актуальны, откройте PR повторно. |
inomdzhon
added
no-stale
i-mirdzhamolov-vk-team
left a comment
i-mirdzhamolov-vk-team
left a comment
Contributor
There was a problem hiding this comment.
В доке https://development.s3.prodcloud.vk.team/pull/10029/1d76d8f8d11337d6b7016aff5d4ee6965caf894f/components/custom-select/index.html чет не могу воспроизвести 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e2e-тестыДизайн-ревьюДокументация фичиОписание
Показываем крестик при фокусе на поиске в CustomSelect
Release notes
Улучшения