Packing GUI #308
Packing GUI #308
Conversation
test file
remram44
added
R-invalid
There was a problem hiding this comment.
I didn't look into the tree yet, but it looks like you should be holding some more state about the current configuration, rather than relying on the configuration file, and non-obvious global state such as flag, numberOfRuns, runName.
The flow seems to be this:
I think it might make sense to keep to usual stack-based procedures, with AddRunWindow being your base state, calling TraceWindow when a new run is to be added, calling editConfigurationWindow when the user is ready to move on to that stage, and have editConfigurationWindow call similarly into renameFileWindow and AddFilesWindow. And remove this switch_frame() method that complicates things for you. That way those objects don't cease to exist during their natural lifetime and can keep state.
reprozip-gui/gui.py
Outdated
| data = yaml.safe_load(fr) | ||
|
|
||
| data['inputs_outputs'][self.index]['name'] = self.fileNameEntry.get() | ||
| with open(self.master,filepath, "w") as fw: |
reprozip-gui/gui.py
Outdated
| with open(self.master.filepath) as fr: | ||
| data = yaml.safe_load(fr) | ||
|
|
||
| if(flag != 3): |
There was a problem hiding this comment.
This is really a hack. You shouldn't be passing this through the attribute on the application, rather it should be set by TraceWindow before switching.
| # Run 0 being the first run | ||
| numberOfRuns = 0 | ||
| #to keep a check on which was the last window visited, -1 saying no widnows prior | ||
| flag = -1 |
There was a problem hiding this comment.
This is only used by AddRunWindow to set the run name, should get rid of it
2 participants
This is a draft. PR opened for code review.
This is a GUI allowing users to trace, edit the config, and pack easily.
cc @BinalModi
see #257