chore(email-mcp): drop bin field from core package#40
Merged
stevenobiajulu merged 1 commit intomainfrom Apr 20, 2026
Merged
Conversation
The core `@usejunior/email-mcp` package and the wrapper `email-agent-mcp` package both declared a `bin` called `email-agent-mcp`, pointing at different files. When both are installed, npm can only create one symlink — the core package wins and the wrapper's bin becomes unreachable. v0.1.6 fixed the resulting silent-exit bug by making cli.js's direct-run guard robust to the symlinked path. This change removes the duplicate bin declaration entirely so the two packages stop fighting for the same bin name at install time. Belt-and-suspenders. The `@usejunior/email-mcp` package is a library consumed by the `email-agent-mcp` wrapper; end users are not expected to invoke its CLI directly. Anyone who was doing so via its bin symlink can still run `node node_modules/@usejunior/email-mcp/dist/cli.js`.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@usejunior/email-mcppackage and theemail-agent-mcpwrapper both declared abinnamedemail-agent-mcppointing at different files. When both are installed, npm can only create one symlink — the core package wins and the wrapper's bin becomes unreachable. That's what caused the silent-exit bug fixed in fix(cli): detect direct run through npm bin symlinks #39 (v0.1.6).@usejunior/email-mcppackage is a library consumed by theemail-agent-mcpwrapper; end users are not expected to invoke its CLI directly. Anyone who was doing so via the bin symlink can still runnode node_modules/@usejunior/email-mcp/dist/cli.js.Test plan
npm run build(all workspaces)npm run test:run→ 492 tests passed across 38 files