[codex] keep direct CLI serve alive for Claude MCP#35
Merged
stevenobiajulu merged 1 commit intomainfrom Apr 16, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
2fefedc to
b876254
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The direct
node .../dist/cli.js serveentrypoint now routes through a smallrunCliDirect()adapter that setsprocess.exitCodeon success instead of callingprocess.exit(code)immediately.A regression test was added to verify the direct
servepath does not force-process-exit after the MCP stdio transport starts.Why
Claude MCP health checks were failing when pointed directly at
packages/email-mcp/dist/cli.js servefrom the main checkout.Root cause: the direct CLI auto-run path awaited
runCli()and then unconditionally calledprocess.exit(code). Forserve,runCli()resolves after stdio transport setup, so the process exited right after startup and before Claude could complete its handshake.Impact
This makes the main checkout usable as a direct Claude MCP runtime target without relying on a separate wrapper or alternate runtime worktree.
Validation
npm run test:run -w @usejunior/email-mcpnpm run build -w @usejunior/email-mcpclaude mcp get email-agent-mcp-worktree-test->Status: ✓ Connectednode packages/email-mcp/dist/cli.js servestayed alive after startup