fix: preserve denyRead precedence in linux mount planner#100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent overlapping Linux filesystem deny rules from re-exposing masked paths by replacing the late exact-path dedupe with subtree-aware mount planning.
The new planner makes
denyReadmasks take precedence over later read-only self-binds fromdenyWrite, mandatory dangerous-path protection, and runtime exec deny, including descendant paths under a masked directory.Resolves #87.
Changes
internal/sandbox/linux_mount_planner.goto plan the late policy overlays fordenyRead, mandatory dangerous-path protection,denyWrite, and runtime exec denydenyRead + denyWritestays masked instead of becoming visible read-onlydenyWriteentries under a masked directory are ignoredinternal/sandbox/linux.goby delegating only the overlay/security phases to the planner and leaving the base, special mounts, and cross-mount repairs imperative~/.sshoverlap and the stronger child-under-masked-parent case