Merged
Conversation
There was a problem hiding this comment.
3 issues found across 9 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="drift/instrumentation/psycopg2/instrumentation.py">
<violation number="1" location="drift/instrumentation/psycopg2/instrumentation.py:222">
P1: InstrumentedConnection.cursor() unconditionally supplies cursor_factory based only on the cursor() argument, which can override a cursor_factory set on connect() and change cursor behavior (e.g., RealDictCursor no longer default). Preserve the connect()-time cursor_factory when cursor() is called without one (e.g., store it on the wrapper and use it as the base_factory).</violation>
<violation number="2" location="drift/instrumentation/psycopg2/instrumentation.py:613">
P2: In REPLAY executemany(), normalize params_list to a list before hashing/matching mocks to keep parity with RECORD mode and avoid iterator/serialization issues.</violation>
<violation number="3" location="drift/instrumentation/psycopg2/instrumentation.py:840">
P2: deserialize_db_value() is applied to all mocked row values and will coerce any ISO-looking string into a datetime (including date-only strings), potentially changing types for text columns. Consider narrowing parsing (e.g., require a time component like 'T' / ':'), or use column type info (type_code) to only deserialize known datetime/timestamp columns.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.