Skip to content

Conversation

@marineAqu
Copy link
Contributor

@marineAqu marineAqu commented Nov 3, 2025

User description

#️⃣연관된 이슈

close: #406

🚀 작업 내용

  • CI/CD 수정 (수동트리거 추가)

🔍 리뷰 요청 사항


PR Type

enhancement


Description

  • CI/CD 워크플로우에 수동 트리거 추가

Diagram Walkthrough

flowchart LR
  CD["CD 워크플로우"] -- "수동 트리거 추가" --> WorkflowDispatch["workflow_dispatch 이벤트"]
Loading

File Walkthrough

Relevant files
Enhancement
cd-for-no-es.yml
CI/CD 워크플로우에 수동 트리거 추가                                                                     

.github/workflows/cd-for-no-es.yml

  • 워크플로우에 'workflow_dispatch' 이벤트 추가
+1/-0     

@marineAqu marineAqu self-assigned this Nov 3, 2025
@marineAqu marineAqu added the ⚙ Setting 개발 환경 세팅 label Nov 3, 2025
@github-actions
Copy link

github-actions bot commented Nov 3, 2025

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

🎫 Ticket compliance analysis 🔶

406 - Partially compliant

Compliant requirements:

  • CI/CD 수정

Non-compliant requirements:

  • elastic search repository 삭제
  • ES 사용 API 수정
⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
입력 옵션 추가

workflow_dispatch 이벤트를 추가하면 수동 트리거가 가능해지지만, 이 설정만으로는 충분하지 않습니다. 이벤트 트리거를 위한 입력 옵션을
정의해야 합니다. 예를 들어, 배포할 환경을 선택할 수 있는 입력 필드를 추가하는 것이 좋습니다.

.github/workflows/cd-for-no-es.yml [4]

 workflow_dispatch:
+  inputs:
+    environment:
+      description: '배포할 환경을 선택하세요.'
+      required: true
+      default: 'production'
Suggestion importance[1-10]: 7

__

Why: Adding input options to the workflow_dispatch event enhances the flexibility and usability of the workflow by allowing manual triggers with specific parameters. This is a useful improvement, though not critical for basic functionality.

Medium

@marineAqu marineAqu merged commit 68ae1c1 into develop-no-es Nov 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants