Add Swift 4 compatibility #108
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffaburt
force-pushed
the
jeffaburt/swift-4
branch
from
6056bb9 to
44d3fd7
Compare
Author
|
There were two additional places I had to include @objc. Please review this again when you're able to. Thanks! |
Member
|
These changes are already in Master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title says it all!
Same end result as #98, but with no conflicts. Unfortunately I don't have write permissions to edit the code in that pull request.
After merging this PR, do you mind releasing a new version of Armchair on CocoaPods? Please and thanks!